Make mooshimeter a package #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyoungtech
commented
Feb 7, 2019
| name='mooshimeter', | ||
| version='0.1.0', | ||
| packages=['mooshimeter', 'mooshimeter.vendor'], | ||
| url='https://github.com/spyoungtech/Mooshimeter-PythonAPI', |
Author
There was a problem hiding this comment.
probably will want to change a couple lines here if merged :)
spyoungtech
commented
Feb 7, 2019
| ``` | ||
|
|
||
| **NOTE:** This package is maintained unofficially. | ||
| It has no official connection to the [official Mooshim repository](https://github.com/mooshim/Mooshimeter-PythonAPI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've gone made some nominal edits to convert this repo into a Python package and make it (in my view anyhow) a little more friendly for new readers. The code changes are strictly organizational and naming related.
I also included a
setup.pyand associated files to make it installable usingpippackage manager and also made this available asmooshimeteron PyPI. There is also anappveyor.ymlfile that makes pushing changes up to PyPI as simple as creating a GitHub release :)Tested minimally with the
Example.pyand all seems well there.If you find this useful, please consider accepting this PR.
Some additional future work I'd like to see would be to port this over to Python3, since Python2 is End-of-life this year. Further, I'm considering creating a minimal GUI for this, perhaps using Jupyter notebook or a simple tkinter desktop gui.